Uploaded image for project: 'rcX - Operating System'
  1. rcX - Operating System
  2. RCX-859

Including HilFileHeader.h, HilFileHeaderV3.h breaks Hilscher Definitions Hil_Compiler.h

    Details

    • Type: Change
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: V2.1.14.2
    • Component/s: General
    • Labels:
      None
    • Sprint:
      SDO Sprint 4
    • Account:
      SDO rcX (SDORCX)

      Description

      Quote from reporter:

      In the beginning og HilFileHeader.h definitions are made for __HIL_PACKED_PRE and __HIL_PACKED_POST and at the end they are undefined again. Thus, if HilFileHeader.h is included after including "Hil_Compiler.h" it will undefine the definitions __HIL_PACKET_PRE and __HIL_PACKED_POST again. This breaks compilation.

      Affect from this problem are use of any of the following headers:

      • HilFileHeader.h
      • HilFileHeaderV3.h
      • rx_Modules.h

      HilFileHeader.h, HilFileHeaderV3.h should not define and undefine symbols defined in namespace of other headers. It should use its own prefix.

      It should be possible to rename the definitions in rcX. They are defined in HilFileHeader.h and HilFileHeaderV3.h and also undefined at the end of both files.

      Renaming them should make no difference since they couldn't be accessed/used outside of those header files before.

        Attachments

          Expenses

            Activity

              Status Description

                People

                • Reporter:
                  AMinor Alexander Minor
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: