Uploaded image for project: 'EtherNet/IP Firmware V3'
  1. EtherNet/IP Firmware V3
  2. PSEISV3-219

Check control flow of CipObj_Call() call to always set a return code in the response message.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: V3.3.1.0, V3.4.0.0
    • Fix Version/s: V3.3.2.0, V3.4.0.0
    • Component/s: None
    • Labels:
      None
    • Account:
      SPC EthernetIp Slave (SPCETHERNE)

      Description

      Currently, it seems like CipAs_AddMember(), CipAsDelMember(), CipAs_UpdateConsume() and CipAs_UpdateProduce() do not set bGRC in the response message. They probably should.

      Investigate on the effect of this. Is a success return code set anywhere else or isn't it set at all? These functions do never fail. Presumably, with the current implementation, there is the possibility that wrong (old) status codes will be reported, since these handlers never set a success status code.

      It may make sense to investigate _all_ command handlers available through CipObj_Call() on this topic, i.e. setting a result code in each possible case of control flow.

       

        Attachments

          Expenses

            Activity

              Status Description

                People

                • Reporter:
                  MBommert Marc Bommert
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: