Uploaded image for project: 'EtherNet/IP Core V2'
  1. EtherNet/IP Core V2
  2. PSEIPCORE-267

Parameter check of attribute 5 (set attribute single) is too strict

    Details

    • Type: Change
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: V2.6.0.0
    • Labels:
      None
    • Account:
      SPC EthernetIp Core (SPCETHERNET)

      Description

      With ticket PSEIPCORE-261 a very strict parameter check has been introduced.
      That change made the API incompatible to previous versions.

      Before the change the host application could send a set attribute service (to attribute 5) with a fix size of sizeof(EIP_TCP_INTERFACE_CONFIG_T). This equals the maximum size that attribute 5 can hold. The sent service data size was independend on how long the domain name actually is. So the host application could set the domain name to an empty string (""), by sending 48 bytes for the domain name, but setting the string lenght to 0 (first 2 bytes of domain name field).

      With the changed behavior (PSEIPCORE-261), the host aplication now has to adapt the service size dependent on the  string length of the domain name. This puts additional burden on the host application that we want to avoid.

      This change was not distributed. It was introduced in one PreRelease version only.

      Proposed change:
      The stack shall not check for an exact data size match. It shall accept that more data than necessary is received.

        Attachments

          Issue Links

            Expenses

              Activity

                Status Description

                  People

                  • Reporter:
                    KMichel Kai Michel
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: